Revert XMLValidator workaround#1590
Merged
Merged
Conversation
Contributor
Author
|
@joseph-robertson Should we do a ResStock test with this? |
joseph-robertson
approved these changes
Jan 17, 2024
joseph-robertson
left a comment
Collaborator
There was a problem hiding this comment.
I pulled this PR into resstock here, and CI was successful: NatLabRockies/resstock#1191.
…o revert_xmlvalidator # Conflicts: # HPXMLtoOpenStudio/measure.xml
Contributor
Author
|
I'm not going to bother running it through CI again. Thanks for testing, @joseph-robertson. |
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Avoid creating our own temp xmlvalidation directories for schematron validation, which was a workaround several years ago to prevent errors due to collisions.
I previously tried removing the workaround but subsequently had to revert it because it was failing on the CI. I forget exactly what the issue was. But this time, it looks like the CI is happy. It's possible that the CI issue was addressed by this change?
Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
EPvalidator.xml) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run