Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow negative Elevation values#1780

Merged
shorowit merged 1 commit into
masterfrom
negative_elevation
Jul 22, 2024
Merged

Allow negative Elevation values#1780
shorowit merged 1 commit into
masterfrom
negative_elevation

Conversation

@shorowit

@shorowit shorowit commented Jul 22, 2024

Copy link
Copy Markdown
Contributor

Pull Request Description

Pulls in hpxmlwg/hpxml#413.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added the bug label Jul 22, 2024
@shorowit shorowit self-assigned this Jul 22, 2024
@shorowit shorowit added the hpxml label Jul 22, 2024

@joseph-robertson joseph-robertson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a resstock datapoint in Imperial County CA (elevation -55.8 ft), and the simulation was successful.

@shorowit shorowit merged commit 3ce3e19 into master Jul 22, 2024
@shorowit shorowit deleted the negative_elevation branch July 22, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants