Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Stratified tank bugfix#1849

Merged
shorowit merged 3 commits into
masterfrom
stratified_tank_bugfix
Oct 4, 2024
Merged

Stratified tank bugfix#1849
shorowit merged 3 commits into
masterfrom
stratified_tank_bugfix

Conversation

@shorowit

@shorowit shorowit commented Oct 4, 2024

Copy link
Copy Markdown
Contributor

Pull Request Description

Closes #1847 and closes #1848.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit

shorowit commented Oct 4, 2024

Copy link
Copy Markdown
Contributor Author

Tiny diffs for HPWHs and stratified tank ERWHs.

@shorowit shorowit requested a review from jmaguire1 October 4, 2024 18:52

@jmaguire1 jmaguire1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for doing this so quickly Scott!

@shorowit shorowit merged commit 745026f into master Oct 4, 2024
@shorowit shorowit deleted the stratified_tank_bugfix branch October 4, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

2 participants