Remove old HPWHs part 2#1205
Merged
Merged
Conversation
…m new technology rather than generation 1 tech. Thanks to @shorowit for pointing this one out.
afontani
approved these changes
Feb 12, 2024
Contributor
|
Follow up to #1190 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We missed one option in options_lookup. I'm keeping an example of a setpoint change (although I don't think anyone is using that), but it now uses current generation technology rather than gen 1 products
Pull Request Description
Revamp one option in options_lookup for HPWHs.
Checklist
Not all may apply:
- [ ] Tests (and test files) have been updated- [ ] Documentation has been updatedopenstudio tasks.rb update_measureshas been run