Speed up TSVFile class#1272
Merged
Merged
Conversation
…reading in the large TSV files is the bottleneck.
joseph-robertson
approved these changes
Jul 15, 2024
joseph-robertson
left a comment
Contributor
There was a problem hiding this comment.
I tried this locally, and w/out a doubt running sampling (or at least the stuff just before sampling) for the national baseline yml is much quicker. Thanks!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Speeds up the TSVFile class. When running smaller sample sizes, the initial reading of the large TSV files is the bottleneck. For e.g. 250 samples, this roughly cuts the time in half.
Checklist
Not all may apply:
openstudio tasks.rb update_measureshas been run