Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ResStockArguments: fix pv/battery present bool args#1292

Merged
joseph-robertson merged 1 commit into
developfrom
resstock-args-bool-fix
Aug 26, 2024
Merged

ResStockArguments: fix pv/battery present bool args#1292
joseph-robertson merged 1 commit into
developfrom
resstock-args-bool-fix

Conversation

@joseph-robertson

@joseph-robertson joseph-robertson commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

Pull Request Description

Arguments pv_system_present and battery_present are bools, not strings. But since we were never setting xxx_num_bedrooms_served greater than geometry_unit_num_bedrooms anyway, I believe this issue was inconsequential.

Checklist

Not all may apply:

@joseph-robertson joseph-robertson added this to the ResStock v3.4.0 milestone Aug 26, 2024
@joseph-robertson joseph-robertson self-assigned this Aug 26, 2024
@joseph-robertson joseph-robertson marked this pull request as ready for review August 26, 2024 21:28
@joseph-robertson joseph-robertson merged commit 7ff4910 into develop Aug 26, 2024
@joseph-robertson joseph-robertson deleted the resstock-args-bool-fix branch August 26, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant