Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Load flexibility yingli#1331

Merged
rajeee merged 44 commits into
load_flexibilityfrom
load_flexibility_yingli
Mar 7, 2025
Merged

Load flexibility yingli#1331
rajeee merged 44 commits into
load_flexibilityfrom
load_flexibility_yingli

Conversation

@Yingli-NLR

@Yingli-NLR Yingli-NLR commented Dec 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pull Request Description

  1. Revise the peak time input json files and related code in the measure, which get rid of the variable "on_peak_duration"
  2. Add setpoint clip function to to prevent excessive heating or cooling
  3. Revise the default value of the load flexibility scenario design
  4. Did a local test run, the run is successful
  5. Add the test to test the run of the whole measure and setpoints are modified as designed

@Yingli-NLR Yingli-NLR requested a review from rajeee December 13, 2024 22:45
rajeee
rajeee reviewed Dec 16, 2024
View reviewed changes
Comment thread measures/ResStockArgumentsPostHPXML/resources/hvac_flexibility/setpoint_modifier.rb Outdated
rajeee
rajeee reviewed Dec 16, 2024
View reviewed changes
Comment thread resources/options_lookup.tsv

@rajeee rajeee Dec 16, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changes are you making on this file? Is it required?

@Yingli-NLR Yingli-NLR Dec 18, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted the loadflex_peak_duration_hours argument in the LoadFlexibility

Yingli-NLR
Yingli-NLR commented Dec 24, 2024
View reviewed changes

@Yingli-NLR Yingli-NLR left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed all comments

Comment thread measures/ResStockArgumentsPostHPXML/resources/hvac_flexibility/setpoint_modifier.rb Outdated
Comment thread resources/options_lookup.tsv

@Yingli-NLR Yingli-NLR Dec 18, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted the loadflex_peak_duration_hours argument in the LoadFlexibility

@Yingli-NLR Yingli-NLR self-assigned this Dec 24, 2024
@willf willf mentioned this pull request Feb 12, 2025
Open
@rajeee rajeee merged commit 482ecdf into load_flexibility Mar 7, 2025
@rajeee rajeee deleted the load_flexibility_yingli branch March 27, 2025 15:35
@joseph-robertson joseph-robertson added this to the ResStock v2025_R1 milestone Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rajeee rajeee rajeee left review comments

Assignees

@Yingli-NLR Yingli-NLR

Labels

None yet

Projects

None yet

Milestone

ResStock v2025_R1

Development

Successfully merging this pull request may close these issues.

3 participants

@Yingli-NLR @rajeee @joseph-robertson