Electric panel, follow-up#1370
Merged
Merged
Conversation
| end | ||
|
|
||
| # Save the hash of applicable upgrade measure arguments | ||
| upgrade_args_hash = measures['ResStockArguments'][0].clone |
Contributor
Author
There was a problem hiding this comment.
Using only applicable arguments (i.e., only those arguments corresponding to options that meet the apply logic) fixes a bug related to:
- retaining HVAC system sizes; previously, it was possible that an HVAC system was being re-sized if (1) an HVAC option didn't meet apply logic (i.e., was being retained), (2) the upgrade system type was the same as the baseline system type (e.g., ASHP to ASHP), and (3) the upgrade included changes in design loads (e.g., envelope). I wouldn't expect much of an impact here since we're now "oversizing" vs. previously sizing to meet the load (assuming previous re-size was a reduction)?
- identifying new electric panel loads; previously, existing loads could be set as new loads in the upgrade building even if they weren't actually being added/upgraded (e.g., electric clothes dryer)
Contributor
There was a problem hiding this comment.
Am I interpreting correctly that the bug also affected the load-based calculation?
lixiliu
reviewed
Mar 31, 2025
Contributor
|
Confirmed the bug has been fixed. |
JLReyna
reviewed
Apr 11, 2025
lixiliu
approved these changes
Apr 23, 2025
lixiliu
left a comment
Contributor
There was a problem hiding this comment.
Run with this branch produces results that were more aligned with expectation. Spot-checking also checks out.
Contributor
Thanks @lixiliu |
afontani
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR:
Related Pull Requests
[related PRs from different repositories]
Related Issues
[What issue(s) is the PR addressing]
Checklist
Required:
Optional (not all items may apply):
openstudio tasks.rb update_measureshas been run