Two Speed and Variable Speed Geothermal Heat Pumps#1372
Merged
Conversation
…db1e0521d 2134db1e0521d Merge branch 'ghp-two-speed-var-speed' into resstock-ghp fded43345dfc8 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed 0e19763bd304b fix ci failure? 4217da26fafde Merge branch 'ghp-two-speed-var-speed' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed 0d8e13d63a4b9 Use predicted load for pump mfr EMS to partially workaround the temperature errors 34176f3a0fc18 Latest results. deb758b4536b5 Merge branch 'ghp-two-speed-var-speed' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed 05282c16fa07d update measures dce75eecded5a fix unit issue in hvac sizing, draft pump mfr EMS(not passing yet) aaee2291516de Latest results. 2a608ecb23276 Merge branch 'ghp-two-speed-var-speed' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed 08c871a7a1abb pump power bugfix using coil speed level, speed ratio, part load ratio instead of unitary plr e14dd0a55f20a using net shr for now de35c3976ae86 Latest results. e5334014549c9 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed f9588c1e33e10 fix argument error 62b06d46e81da iq test file using advanced for two speed system 132ff8c506121 Merge branch 'ghp-two-speed-var-speed' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed 7338de9880db0 first cut to add optional geothermal model type input 0344237cde7e5 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed and small cleanup cc43622b960da Latest results. f4aa3f999a18d Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed cf7afd9c22b36 Merge branch 'ghp-two-speed-var-speed' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed a837c44d7c581 update varspeed performance curves, change pump control type to continuous for var speed system 6c6e2da79c9a8 Latest results. 7f10ef2c70ab6 hers unit test ddc61f91e7702 Merge branch 'ghp-two-speed-var-speed' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed c15161d54f2e7 remove exclusion of hvac sizing test for var speed system 5fb94c5c81f5e Latest results. 80ef26ba847a0 one more test file with compressor type 8db955128db00 add var speed system 9d717ad0f175f add compressor type to one more gshp test file e282f37162a50 revert making compressor type required in BuildHPXML, 77ef6e7f3da1f buildHPXML fbf72b3d28d1b require compressortype inputs, fix unit tests, add docs and changelog c8ef094538afe Merge branch 'ghp-two-speed-var-speed' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed fecc6950eab10 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed 941a0596ae5ec For two speed, set water flow curves to constant 1.0 values 05243cd79b83f Merge branch 'ghp-two-speed-var-speed' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed 35cce9ab546ab change the ghp efficiencies 52aa253151a72 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed af35dedfb4076 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed 130e448fa5daf Latest results. 00aa08d2de6f4 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed f7b74a3969bba Latest results. ec12831b72fb0 fix test validation 302d4a8d077de Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed 7cabcbc9a7efe iq ems 1010b16a2939b fix sizing unit test ab22fcc20855b Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed d1d0cc8ba6e0b oops, remove debugging statements b1512e2687df5 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed 7facd8860d9c8 bugfixes, installation quality program(haven't finished yet) 58e8142907d93 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed ed642d8914605 Added temperature max/min values to curves, fixed airflow and water flow quadratic curves (fixed coefficients orders, and fixed some curves that are not normalized). c883e62211936 bugfix 4615f89ab3ac8 hvac sizing cleanups for two speed GSHP, added rated cop ratios at each speed cba4f31077db0 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed 2182a8f4890b5 updated performance curves, capacity ratios, cfm/tons based on E+ rated conditions, added more inputs, a few questions, store progress 346d8c935f650 added performance curves for two speed gshp, more assumptions and inputs added. 0788320b44787 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed 74e100c817822 fix issues, add heating coil object f41d4f1cdb5dd Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed 6c0629b2057c5 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ghp-two-speed-var-speed 100e02a40f296 added test files, create coil object with placeholders git-subtree-dir: resources/hpxml-measures git-subtree-split: 2134db1e0521d81e0a182a5f0cb6d58de8b21e5a
…8474864e3 b9708474864e3 Merge branch 'ghp-two-speed-var-speed' into resstock-ghp a3e59be5360eb Pass hpxml_header through. git-subtree-dir: resources/hpxml-measures git-subtree-split: b9708474864e3e13a315020854c50ac823f7c43f
…dff43fa6d 7c63dff43fa6d Merge branch 'ghp-two-speed-var-speed' into resstock-ghp a3d7eb0458219 Latest results. 613c7e331abe4 fix a typo 99a13f7a02792 Latest results. git-subtree-dir: resources/hpxml-measures git-subtree-split: 7c63dff43fa6de7dff5ad3c33aef0f229347c718
… model in OS-HPXML
…when merging in GHP updates
4c63cdb to
979185b
Compare
…atest-os-hpxml-ghp
Contributor
|
@afontani: Do we want to do both thermally enhanced grout AND thermally enhanced pipes, or just grout? I know we specifically told GTO we'd do grout, I don't remember ever talking about pipes. Maybe we want to do both anyways even if we didn't explicitly say so, I just want to flag that I think this isn't quite what we said. |
Contributor
Author
I included pipes based on contents of the draft single-speed measure doc. |
joseph-robertson
commented
May 5, 2025
| HVAC Heating Efficiency "GSHP, EER 20.2, COP 4.2" ResStockArguments heating_system_type=none heating_system_heating_efficiency=0 heating_system_heating_capacity=auto heating_system_heating_autosizing_limit=auto heating_system_fraction_heat_load_served=1 heating_system_has_flue_or_chimney=auto heat_pump_type=ground-to-air heat_pump_heating_efficiency_type=COP heat_pump_heating_efficiency=4.2 heat_pump_cooling_efficiency_type=EER heat_pump_cooling_efficiency=20.2 heat_pump_sizing_methodology=ACCA heat_pump_backup_sizing_methodology=auto heat_pump_heating_capacity=auto heat_pump_heating_autosizing_limit=auto heat_pump_fraction_heat_load_served=1 heat_pump_cooling_capacity=auto heat_pump_cooling_autosizing_limit=auto heat_pump_fraction_cool_load_served=1 heat_pump_backup_type=integrated heat_pump_backup_fuel=electricity heat_pump_backup_heating_efficiency=1 heat_pump_backup_heating_capacity=auto heat_pump_backup_heating_autosizing_limit=auto geothermal_loop_configuration=vertical geothermal_loop_borefield_configuration=auto geothermal_loop_loop_flow=auto geothermal_loop_boreholes_count=auto geothermal_loop_boreholes_length=auto geothermal_loop_boreholes_spacing=auto geothermal_loop_boreholes_diameter=auto geothermal_loop_grout_type=auto geothermal_loop_pipe_type=auto geothermal_loop_pipe_diameter=auto simulation_control_ground_to_air_heat_pump_model_type=auto | ||
| HVAC Heating Efficiency "GSHP, EER 20.5, COP 4.0" ResStockArguments heating_system_type=none heating_system_heating_efficiency=0 heating_system_heating_capacity=auto heating_system_heating_autosizing_limit=auto heating_system_fraction_heat_load_served=1 heating_system_has_flue_or_chimney=auto heat_pump_type=ground-to-air heat_pump_heating_efficiency_type=COP heat_pump_heating_efficiency=4.0 heat_pump_cooling_efficiency_type=EER heat_pump_cooling_efficiency=20.5 heat_pump_sizing_methodology=MaxLoad heat_pump_backup_sizing_methodology=auto heat_pump_heating_capacity=auto heat_pump_heating_autosizing_limit=auto heat_pump_fraction_heat_load_served=1 heat_pump_cooling_capacity=auto heat_pump_cooling_autosizing_limit=auto heat_pump_fraction_cool_load_served=1 heat_pump_backup_type=none heat_pump_backup_fuel=electricity heat_pump_backup_heating_efficiency=1 heat_pump_backup_heating_capacity=auto heat_pump_backup_heating_autosizing_limit=auto geothermal_loop_configuration=vertical geothermal_loop_borefield_configuration=auto geothermal_loop_loop_flow=auto geothermal_loop_boreholes_count=auto geothermal_loop_boreholes_length=auto geothermal_loop_boreholes_spacing=auto geothermal_loop_boreholes_diameter=auto geothermal_loop_grout_type=auto geothermal_loop_pipe_type=auto geothermal_loop_pipe_diameter=auto simulation_control_ground_to_air_heat_pump_model_type=auto | ||
| HVAC Heating Efficiency "GSHP, EER 16.6, COP 3.6" ResStockArguments heating_system_type=none heating_system_heating_efficiency=0 heating_system_heating_capacity=auto heating_system_heating_autosizing_limit=auto heating_system_fraction_heat_load_served=1 heating_system_has_flue_or_chimney=auto heat_pump_type=ground-to-air heat_pump_heating_efficiency_type=COP heat_pump_heating_efficiency=3.6 heat_pump_cooling_efficiency_type=EER heat_pump_cooling_efficiency=16.6 heat_pump_sizing_methodology=ACCA heat_pump_backup_sizing_methodology=auto heat_pump_heating_capacity=auto heat_pump_heating_autosizing_limit=auto heat_pump_fraction_heat_load_served=1 heat_pump_cooling_capacity=auto heat_pump_cooling_autosizing_limit=auto heat_pump_fraction_cool_load_served=1 heat_pump_backup_type=integrated heat_pump_backup_fuel=electricity heat_pump_backup_heating_efficiency=1 heat_pump_backup_heating_capacity=auto heat_pump_backup_heating_autosizing_limit=auto heat_pump_heating_capacity_retention_fraction=auto heat_pump_heating_capacity_retention_temp=auto heat_pump_is_ducted=true heat_pump_backup_heating_lockout_temp=auto heat_pump_compressor_lockout_temp=auto heat_pump_cooling_compressor_type=single stage heat_pump_cooling_sensible_heat_fraction=auto heat_pump_crankcase_heater_watts=auto geothermal_loop_configuration=vertical geothermal_loop_borefield_configuration=auto geothermal_loop_loop_flow=auto geothermal_loop_boreholes_count=auto geothermal_loop_boreholes_length=auto geothermal_loop_boreholes_spacing=auto geothermal_loop_boreholes_diameter=auto geothermal_loop_grout_type=auto geothermal_loop_pipe_type=auto geothermal_loop_pipe_diameter=auto simulation_control_ground_to_air_heat_pump_model_type=auto | ||
| HVAC Heating Efficiency "GSHP, EER 18.6, COP 3.8" ResStockArguments heating_system_type=none heating_system_heating_efficiency=0 heating_system_heating_capacity=auto heating_system_heating_autosizing_limit=auto heating_system_fraction_heat_load_served=1 heating_system_has_flue_or_chimney=auto heat_pump_type=ground-to-air heat_pump_heating_efficiency_type=COP heat_pump_heating_efficiency=3.8 heat_pump_cooling_efficiency_type=EER heat_pump_cooling_efficiency=18.6 heat_pump_sizing_methodology=MaxLoad heat_pump_backup_sizing_methodology=auto heat_pump_heating_capacity=auto heat_pump_heating_autosizing_limit=auto heat_pump_fraction_heat_load_served=1 heat_pump_cooling_capacity=auto heat_pump_cooling_autosizing_limit=auto heat_pump_fraction_cool_load_served=1 heat_pump_backup_type=none heat_pump_backup_fuel=electricity heat_pump_backup_heating_efficiency=1 heat_pump_backup_heating_capacity=auto heat_pump_backup_heating_autosizing_limit=auto heat_pump_heating_capacity_retention_fraction=auto heat_pump_heating_capacity_retention_temp=auto heat_pump_is_ducted=true heat_pump_backup_heating_lockout_temp=auto heat_pump_compressor_lockout_temp=auto heat_pump_cooling_compressor_type=single stage heat_pump_cooling_sensible_heat_fraction=auto heat_pump_crankcase_heater_watts=auto geothermal_loop_configuration=vertical geothermal_loop_borefield_configuration=auto geothermal_loop_loop_flow=auto geothermal_loop_boreholes_count=auto geothermal_loop_boreholes_length=auto geothermal_loop_boreholes_spacing=auto geothermal_loop_boreholes_diameter=auto geothermal_loop_grout_type=thermally enhanced geothermal_loop_pipe_type=thermally enhanced geothermal_loop_pipe_diameter=auto simulation_control_ground_to_air_heat_pump_model_type=experimental |
Contributor
Author
There was a problem hiding this comment.
Should "experimental" be expressed in these options names? Probably not.
Contributor
@joseph-robertson : I did see this. Thermally enhanced pipes and grout are fine. |
Contributor
Have not had final decision yet - likely dual fuel will be ACCA and ccASHP will be max load. |
joseph-robertson
commented
May 6, 2025
| project_testing/testing_baseline/results_csvs/results_up00.csv | ||
| project_national/sdr_upgrades_tmy3/results_csvs/results_up00.csv | ||
| project_national/sdr_upgrades_tmy3/results_csvs/results_up16.csv | ||
| project_national/sdr_upgrades_tmy3/results_csvs/results_up18.csv |
Contributor
Author
There was a problem hiding this comment.
Here we want to upload the results csv corresponding to "Envelope Only - Light Touch Envelope". Since we've modified the SDR yml file, we need to adjust this file name.
Contributor
Right now we are using MaxLoad for the upgrade options. |
afontani
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Uses new features introduced in NatLabRockies/OpenStudio-HPXML#1878.
Add lookup options:
Along with GSHP, EER 20.5, COP 4.0 (two stage), these options have
geothermal_loop_grout_type=thermally enhancedandgeothermal_loop_pipe_type=thermally enhanced.Update sdr_upgrades_tmy3.yml with upgrades:
GHP Dual Speed with Enhanced Grout + Light Touch Envelope + Full Appliance Electrification with EfficiencyRelated Pull Requests
[related PRs from different repositories]
Related Issues
[What issue(s) is the PR addressing]
Checklist
Required:
Optional (not all items may apply):
openstudio tasks.rb update_measureshas been run