Clean up duct options#1396
Merged
Merged
Conversation
Collaborator
|
Once this (hopefully) gets merged into develop, and develop gets merged into latest-os-hpxml (@joseph-robertson or I can do that?), I can merge latest-os-hpxml into buildreshpxml on resstock side and address the Ducts:Supply and Ducts:Return refactor in options_lookup there. |
…_up_duct_options # Conflicts: # test/base_results/upgrades/timeseries/buildstockbatch.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Removes a bunch of unused duct options.
(There was an 85% duct leakage option?! That makes no sense.)
Checklist
Required:
Optional (not all items may apply):
openstudio tasks.rb update_measureshas been run