Simplify options in sdr_upgrades_tmy3.yml, follow-up#1428
Merged
Conversation
Contributor
Author
|
Include more argument description for |
…into simplify-upgrade-options2
afontani
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Improve/clarify names for options:
For these options, set:
heat_pump_backup_type=autoheat_pump_backup_fuel=autoheat_pump_backup_heating_efficiency=autoRemove all the (obsolete) "Dual-Fuel ASHP, SEER 16, 9.2 HSPF, Integrated Backup, xx% AFUE xx, 5F-40F switchover band" options from the lookup.
Move
heat_pump_backup_use_existing_systemargument assignment from parameterHeat Pump BackuptoHVAC Heating Efficiency. For each of the above options, set it totrue. Delete theHeat Pump Backupparameter row from the lookup.A
Required argument 'heat_pump_backup_fuel' not provided for measure 'BuildResidentialHPXML'.error will now be thrown when trying to use, e.g., the "Dual-Fuel ASHP, SEER 16, 9.2 HSPF, Existing Backup, 5F-40F switchover band" option withoutheat_pump_backup_use_existing_system=true.Related Pull Requests
#1074
Related Issues
[What issue(s) is the PR addressing]
Checklist
Required:
Optional (not all items may apply):
openstudio tasks.rb update_measureshas been run