Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Simplify options in sdr_upgrades_tmy3.yml, follow-up#1428

Merged
afontani merged 29 commits into
developfrom
simplify-upgrade-options2
Jun 18, 2025
Merged

Simplify options in sdr_upgrades_tmy3.yml, follow-up#1428
afontani merged 29 commits into
developfrom
simplify-upgrade-options2

Conversation

@joseph-robertson

@joseph-robertson joseph-robertson commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

Pull Request Description

Improve/clarify names for options:

  • "ASHP, SEER 16, 9.2 HSPF, Integrated Backup, 5F-40F switchover band" to "ASHP, SEER 16, 9.2 HSPF, Existing Backup, 5F-40F switchover band"
  • "ASHP, SEER 16, 9.2 HSPF, Separate Backup" to "ASHP, SEER 16, 9.2 HSPF, Existing Backup"
  • "MSHP, SEER 16, 9.2 HSPF, Separate Backup, Max Load" to "MSHP, SEER 16, 9.2 HSPF, Existing Backup, Max Load"

For these options, set:

  • heat_pump_backup_type=auto
  • heat_pump_backup_fuel=auto
  • heat_pump_backup_heating_efficiency=auto

Remove all the (obsolete) "Dual-Fuel ASHP, SEER 16, 9.2 HSPF, Integrated Backup, xx% AFUE xx, 5F-40F switchover band" options from the lookup.

Move heat_pump_backup_use_existing_system argument assignment from parameter Heat Pump Backup to HVAC Heating Efficiency. For each of the above options, set it to true. Delete the Heat Pump Backup parameter row from the lookup.

A Required argument 'heat_pump_backup_fuel' not provided for measure 'BuildResidentialHPXML'. error will now be thrown when trying to use, e.g., the "Dual-Fuel ASHP, SEER 16, 9.2 HSPF, Existing Backup, 5F-40F switchover band" option without heat_pump_backup_use_existing_system=true.

Related Pull Requests

#1074

Related Issues

[What issue(s) is the PR addressing]

Checklist

Required:

Optional (not all items may apply):

@joseph-robertson joseph-robertson added this to the ResStock v3.5.0 milestone Jun 4, 2025
@joseph-robertson joseph-robertson self-assigned this Jun 4, 2025
@joseph-robertson joseph-robertson marked this pull request as ready for review June 5, 2025 13:40
@joseph-robertson joseph-robertson requested a review from shorowit June 5, 2025 13:48
@joseph-robertson

Copy link
Copy Markdown
Contributor Author

Include more argument description for heat_pump_backup_use_existing_system around backup fuel/efficiency being overwritten.

@joseph-robertson joseph-robertson requested review from afontani and removed request for shorowit June 9, 2025 21:26
@afontani afontani merged commit e7e3885 into develop Jun 18, 2025
@afontani afontani deleted the simplify-upgrade-options2 branch June 18, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants