Clean up the SDR yaml file#1429
Merged
Merged
Conversation
This reverts commit 76bc471.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Clean up the SDR yaml file by moving anchors to the reference section of the yaml. Remove non-SDR upgrades for the 9/30/2025 release.
Future Improvements
There are potential improvements in reusing more anchors, allowing changes to occur in one place and updating the logic in other places accordingly. I am not thrilled by the names of the anchors now. I think we need some sort of naming scheme that helps identify what the anchor does (like:
option_ashp_seer_11_hspf_9orapply_logic_occupied_units). There are also naming conditions specific to ASHPs, but are used in both ASHPs and GHPs.Related BSB Schema Issue: NatLabRockies/buildstockbatch#498
Checklist
Required:
Optional (not all items may apply):
openstudio tasks.rb update_measureshas been run