Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Clean up the SDR yaml file#1429

Merged
afontani merged 13 commits into
developfrom
clean_up_sdr_yml
Jun 11, 2025
Merged

Clean up the SDR yaml file#1429
afontani merged 13 commits into
developfrom
clean_up_sdr_yml

Conversation

@afontani

@afontani afontani commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

Pull Request Description

Clean up the SDR yaml file by moving anchors to the reference section of the yaml. Remove non-SDR upgrades for the 9/30/2025 release.

Future Improvements

There are potential improvements in reusing more anchors, allowing changes to occur in one place and updating the logic in other places accordingly. I am not thrilled by the names of the anchors now. I think we need some sort of naming scheme that helps identify what the anchor does (like: option_ashp_seer_11_hspf_9 or apply_logic_occupied_units). There are also naming conditions specific to ASHPs, but are used in both ASHPs and GHPs.

Related BSB Schema Issue: NatLabRockies/buildstockbatch#498

Checklist

Required:

Optional (not all items may apply):

@afontani afontani requested a review from rajeee June 11, 2025 13:27
@afontani afontani marked this pull request as ready for review June 11, 2025 13:27
@afontani afontani self-assigned this Jun 11, 2025
@afontani afontani merged commit 9f06dba into develop Jun 11, 2025
28 of 30 checks passed
@joseph-robertson joseph-robertson added this to the ResStock v2025_R1 milestone Sep 4, 2025
@rHorsey rHorsey deleted the clean_up_sdr_yml branch October 27, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants