Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Catch failures even if no step_failure or eplustout_err#1435

Merged
joseph-robertson merged 7 commits into
developfrom
fail_fix
Jun 17, 2025
Merged

Catch failures even if no step_failure or eplustout_err#1435
joseph-robertson merged 7 commits into
developfrom
fail_fix

Conversation

@rajeee

@rajeee rajeee commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

Pull Request Description

Follow up to #1423. Currently, in develop, failures caused by E+ are slipping by because no step_failure were produced. This fixes the problem by catching errors even if step_failures column is not present. In addition, also allow for printing eplusout_err when they are available through a BSB PR.

When it is working fully, it will produce output like this:

Checking file: /Users/radhikar/Downloads/buildstockbatch_results_sdr_raw_csvs (1)/results_up07.csv
Found 1 failures in /Users/radhikar/Downloads/buildstockbatch_results_sdr_raw_csvs (1)/results_up07.csv:
  1. Building ID: 99995
     Step Failures: Step failure details not available
     eplusout_err:
    Program Version,EnergyPlus, Version 24.2.0-94a887817b, YMD=2025.06.16 19:34,
   ** Warning ** PerformancePrecisionTradeoffs: Carroll MRT radiant exchange method is selected.
   ************* Note that the following warning(s) may/will occur if you have not enclosed your zone completely.
   ** Warning ** Entered Zone Volumes differ from calculated zone volume(s).
   **   ~~~   ** ...use Output:Diagnostics,DisplayExtraWarnings; to show more details on individual zones.
   ** Warning ** CalculateZoneVolume: 2 zones are not fully enclosed. For more details use:  Output:Diagnostics,DisplayExtrawarnings;
   ** Warning ** Check input. Pump nominal power or motor efficiency is set to 0, for pump=DHW LOOP PUMP
   ** Warning ** Output:Meter: invalid Key Name="DISTRICTHEATINGWATER:FACILITY" - not found.
   ** Warning ** Output:Meter: invalid Key Name="DISTRICTCOOLING:FACILITY" - not found.
   ** Warning ** Output:Meter:MeterFileOnly requested for "Electricity:Facility" (TimeStep), already on "Output:Meter". Will report to both eplusout.eso and eplusout.mtr
   ************* Testing Individual Branch Integrity
   ************* All Branches passed integrity testing
   ************* Testing Individual Supply Air Path Integrity
   ************* All Supply Air Paths passed integrity testing
   ************* Testing Individual Return Air Path Integrity
   ************* All Return Air Paths passed integrity testing
   ************* No node connection errors were found.
   ************* Beginning Simulation
   ** Severe  ** Plant temperatures are getting far too hot, check controls and relative loads and capacities
   **   ~~~   **  During Warmup, Environment=RUN PERIOD 1, at Simulation time=01/01 20:00 - 20:15
   **   ~~~   ** PlantLoop Name (Demand Side) = GROUND SOURCE HEAT PUMP CONDENSER LOOP
   **   ~~~   ** PlantLoop Setpoint Temperature=11.9 {C}
   **   ~~~   ** PlantLoop Inlet Node (LoopSideLocation::Supply) does not have a Setpoint.
   **   ~~~   ** PlantLoop Inlet Node (LoopSideLocation::Demand) does not have a Setpoint.
   **   ~~~   ** PlantLoop Outlet Node (LoopSideLocation::Supply) has a Setpoint.
   **   ~~~   ** PlantLoop Outlet Node (LoopSideLocation::Demand) does not have a Setpoint.
   **   ~~~   ** PlantLoop Outlet Node (DemandSide) "NODE 7" has temperature=251.0 {C}
   **   ~~~   ** PlantLoop Inlet Node (DemandSide) "NODE 6" has temperature=-19.8 {C}
   **   ~~~   ** PlantLoop Minimum Temperature=1.7 {C}
   **   ~~~   ** PlantLoop Maximum Temperature=48.9 {C}
   **   ~~~   ** PlantLoop Flow Request (LoopSideLocation::Supply)=0.0 {kg/s}
   **   ~~~   ** PlantLoop Flow Request (LoopSideLocation::Demand)=0.4 {kg/s}
   **   ~~~   ** PlantLoop Node (DemandSide) "NODE 7" has mass flow rate =0.4 {kg/s}
   **   ~~~   ** PlantLoop PumpHeat (LoopSideLocation::Supply)=6.3 {W}
   **   ~~~   ** PlantLoop PumpHeat (LoopSideLocation::Demand)=0.0 {W}
   **   ~~~   ** PlantLoop Cooling Demand=421245.5 {W}
   **   ~~~   ** PlantLoop Heating Demand=0.0 {W}
   **   ~~~   ** PlantLoop Demand not Dispatched=0.0 {W}
   **   ~~~   ** PlantLoop Unmet Demand=59987.5 {W}
   **   ~~~   ** PlantLoop Capacity=0.0 {W}
   **   ~~~   ** PlantLoop Capacity (LoopSideLocation::Supply)=0.0 {W}
   **   ~~~   ** PlantLoop Capacity (LoopSideLocation::Demand)=0.0 {W}
   **   ~~~   ** PlantLoop Operation Scheme=GROUND SOURCE HEAT PUMP CONDENSER LOOP OPERATION SCHEMES
   **   ~~~   ** PlantLoop Operation Dispatched Load = 0.0 {W}
   **   ~~~   ** PlantLoop Operation Dispatched Load (LoopSideLocation::Supply)= 0.0 {W}
   **   ~~~   ** PlantLoop Operation Dispatched Load (LoopSideLocation::Demand)= 0.0 {W}
   **   ~~~   ** Branches on the Loop.
   **   ~~~   ** Demand Branches:
   **   ~~~   **   GROUND SOURCE HEAT PUMP CONDENSER LOOP DEMAND INLET BRANCH
   **   ~~~   **     Components on Branch:
   **   ~~~   **       PIPE:ADIABATIC:PIPE ADIABATIC 4
   **   ~~~   **   GROUND SOURCE HEAT PUMP CONDENSER LOOP DEMAND BRANCH 1
   **   ~~~   **     Components on Branch:
   **   ~~~   **       COIL:HEATING:WATERTOAIRHEATPUMP:VARIABLESPEEDEQUATIONFIT:GROUND SOURCE HEAT PUMP HTG COIL
   **   ~~~   **   GROUND SOURCE HEAT PUMP CONDENSER LOOP DEMAND BRANCH 2
   **   ~~~   **     Components on Branch:
   **   ~~~   **       COIL:COOLING:WATERTOAIRHEATPUMP:VARIABLESPEEDEQUATIONFIT:GROUND SOURCE HEAT PUMP CLG COIL
   **   ~~~   **   GROUND SOURCE HEAT PUMP CONDENSER LOOP DEMAND BRANCH 3
   **   ~~~   **     Components on Branch:
   **   ~~~   **       PIPE:ADIABATIC:PIPE ADIABATIC 2
   **   ~~~   **   GROUND SOURCE HEAT PUMP CONDENSER LOOP DEMAND BYPASS BRANCH
   **   ~~~   **     Components on Branch:
   **   ~~~   **       PIPE:ADIABATIC:GROUND SOURCE HEAT PUMP CONDENSER LOOP DEMAND BYPASS PIPE
   **   ~~~   **   GROUND SOURCE HEAT PUMP CONDENSER LOOP DEMAND OUTLET BRANCH
   **   ~~~   **     Components on Branch:
   **   ~~~   **       PIPE:ADIABATIC:PIPE ADIABATIC 5
   **   ~~~   ** Supply Branches:
   **   ~~~   **   GROUND SOURCE HEAT PUMP CONDENSER LOOP SUPPLY INLET BRANCH
   **   ~~~   **     Components on Branch:
   **   ~~~   **       PUMP:VARIABLESPEED:GROUND SOURCE HEAT PUMP PUMP
   **   ~~~   **   GROUND SOURCE HEAT PUMP CONDENSER LOOP SUPPLY BRANCH 1
   **   ~~~   **     Components on Branch:
   **   ~~~   **       GROUNDHEATEXCHANGER:SYSTEM:GROUND SOURCE HEAT PUMP EXCHANGER
   **   ~~~   **   GROUND SOURCE HEAT PUMP CONDENSER LOOP SUPPLY BRANCH 2
   **   ~~~   **     Components on Branch:
   **   ~~~   **       PIPE:ADIABATIC:PIPE ADIABATIC 1
   **   ~~~   **   GROUND SOURCE HEAT PUMP CONDENSER LOOP SUPPLY OUTLET BRANCH
   **   ~~~   **     Components on Branch:
   **   ~~~   **       PIPE:ADIABATIC:PIPE ADIABATIC 3
   **   ~~~   ** *************************
   **   ~~~   ** Possible things to look for to correct this problem are:
   **   ~~~   **   Capacity, Operation Scheme, Mass flow problems, Pump Heat building up over time.
   **   ~~~   **   Try a shorter runperiod to stop before it fatals and look at
   **   ~~~   **     lots of node time series data to see what is going wrong.
   **   ~~~   **   If this is happening during Warmup, you can use Output:Diagnostics,ReportDuringWarmup;
   **   ~~~   **   This is detected at the loop level, but the typical problems are in the components.
   **  Fatal  ** CheckForRunawayPlantTemps: Simulation terminated because of run away plant temperatures, too hot
   ...Summary of Errors that led to program termination:
   ..... Reference severe error count=1
   ..... Last severe error=Plant temperatures are getting far too hot, check controls and relative loads and capacities
   *************
   ************* ===== Recurring Error Summary =====
   ************* The following recurring error messages occurred.
   *************
   *************  ** Warning ** Plant loop exceeding upper temperature limit, PlantLoop="GROUND SOURCE HEAT PUMP CONDENSER LOOP"
   *************  **   ~~~   **   This error occurred 22 total times;
   *************  **   ~~~   **   during Warmup 22 times;
   *************  **   ~~~   **   during Sizing 0 times.
   *************  **   ~~~   **   Max=250.992741
   *************
   *************  ** Warning ** Plant loop falling below lower temperature limit, PlantLoop="GROUND SOURCE HEAT PUMP CONDENSER LOOP"
   *************  **   ~~~   **   This error occurred 15 total times;
   *************  **   ~~~   **   during Warmup 15 times;
   *************  **   ~~~   **   during Sizing 0 times.
   *************  **   ~~~   **   Min=-19.172643
   *************
   ************* EnergyPlus Warmup Error Summary. During Warmup: 0 Warning; 1 Severe Errors.
   ************* EnergyPlus Sizing Error Summary. During Sizing: 0 Warning; 0 Severe Errors.
   ************* EnergyPlus Terminated--Fatal Error Detected. 44 Warning; 1 Severe Errors; Elapsed Time=00hr 00min  0.12sec


ERROR: 1 simulation(s) failed. Check the logs above for details.

Related Pull Requests

[related PRs from different repositories]

Related Issues

[What issue(s) is the PR addressing]

Checklist

Required:

Optional (not all items may apply):

@joseph-robertson joseph-robertson merged commit a151b6e into develop Jun 17, 2025
@joseph-robertson joseph-robertson deleted the fail_fix branch June 17, 2025 22:58
@afontani afontani assigned afontani and rajeee and unassigned afontani Jul 9, 2025
@joseph-robertson joseph-robertson added this to the ResStock v2025_R1 milestone Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants