Fix applicability column_type#1439
Conversation
joseph-robertson
left a comment
There was a problem hiding this comment.
What is changing in the results_upXX.csv files?
False to false and True to true. |
joseph-robertson
left a comment
There was a problem hiding this comment.
So the gist here is that you're having buildstockbatch change the case of fields in build_existing_model.applicable, apply_upgrade.applicable, etc so that downstream processing is handled properly?
| if [[ $(git diff --cached --exit-code) ]]; then | ||
| git config --global user.email "[email protected]" | ||
| git config --global user.name "GitHub Action" | ||
| git commit -m "Update documentation." |
There was a problem hiding this comment.
Are these "[skip ci]" additions necessary?
There was a problem hiding this comment.
I am not sure. I thought it would help with "Waiting" (see below) but looks like they don't.
| aws: | ||
| region_name: us-west-2 | ||
| s3: | ||
| bucket: resstock-core | ||
| prefix: resstock_ci | ||
| athena: | ||
| glue_service_role: service-role/AWSGlueServiceRole-default | ||
| database_name: resstock_core | ||
| max_crawling_time: 1200 |
There was a problem hiding this comment.
Are these lines uncommented just for testing?
There was a problem hiding this comment.
No - they will remain uncommented. I have a script that will take them out in CI when not needed
There was a problem hiding this comment.
I see. I read the description above in remove_aws_from_yaml.py - makes sense.
c5bc4db to
0184670
Compare
Pull Request Description
Fix for a minor error on the applicability column dtype in postprocessing code. To help catch these kind of errors in the future, also upload the files to s3 and create Athena tables out of them. The resstockpostproc tests can then run test against those Athena tables to validate the data.
Related Pull Requests
Need this BSB PR: NatLabRockies/buildstockbatch#501
Related Issues
[What issue(s) is the PR addressing]
Checklist
Required:
Optional (not all items may apply):
openstudio tasks.rb update_measureshas been run