Sdr2025 furnaces#1445
Merged
Merged
Conversation
yml, options lookup adjusted, and timeseries analysis
revised logic
revised upgrades and options lookup
…nto sdr2025_furnaces
error in naming and mismatches
lixiliu
reviewed
Aug 15, 2025
lixiliu
reviewed
Aug 15, 2025
lixiliu
reviewed
Aug 15, 2025
lixiliu
reviewed
Aug 15, 2025
| - or: | ||
| - HVAC Cooling Efficiency|AC, SEER 8 | ||
| - HVAC Cooling Efficiency|AC, SEER 10 | ||
| - HVAC Cooling Efficiency|AC, SEER 13 |
Contributor
There was a problem hiding this comment.
Add - HVAC Cooling Efficiency|AC, SEER 15, it could be a slight downgrade but it's for the same reason above.
lixiliu
reviewed
Aug 15, 2025
lixiliu
reviewed
Aug 15, 2025
lixiliu
reviewed
Aug 15, 2025
lixiliu
reviewed
Aug 15, 2025
revised apply logic, renamed package based on changes
apply logic for references more clear
sdr_upgrade_tm3 yml updated with upgrades as well
g Lines starting with '#' will be ignored, and an empty message aborts merged develop into sdr furnaces branch
lixiliu
reviewed
Aug 18, 2025
lixiliu
reviewed
Aug 18, 2025
lixiliu
reviewed
Aug 18, 2025
| - HVAC Heating Efficiency|Fuel Furnace, 85% AFUE | ||
| lifetime: 15 | ||
|
|
||
| - upgrade_name: reference_ac_furnace |
Contributor
There was a problem hiding this comment.
Feel free to make this upgrade name more specific.
renamed the furnace upgrades to be more descriptive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
furnaces, NG for all
Fuel oil, and propane
Related Pull Requests
Related Issues
I have some yml logic and some options lookup changes
Checklist
Required:
Optional (not all items may apply):
openstudio tasks.rb update_measureshas been run