Conversation
| OPENSTUDIO_EXT: deb | ||
| OPENSTUDIO_URL: https://github.com/NREL/OpenStudio/releases/download/v3.9.0 | ||
| BUILDSTOCK_BRANCH: develop | ||
| BUILDSTOCK_BRANCH: pp_fix |
There was a problem hiding this comment.
Does this need to get changed back before merging?
There was a problem hiding this comment.
Yes, will switch these back before merging.
| print(f"Processing baseline file: {baseline_file}") | ||
| baseline_df = pl.scan_parquet(baseline_file) | ||
| failed_bldgs = ( | ||
| baseline_df.filter(pl.col("completed_status") == "Fail") |
There was a problem hiding this comment.
Does ResStock ever have situations where the status is blank or "Success" but there are no numbers in the results data? ComStock has weird failure modes sometimes that we have to catch. If you haven't seen that probably don't need to worry about it.
There was a problem hiding this comment.
Yeah, those three are the only values I have seen. For the GHP upgrade with lots of failures (and possible weird corner cases), that's all we have.
| missing_bldgs_df = missing_bldgs_df.join(upgrade_name_df, how="cross") | ||
| upgrade = pl.concat([upgrade, missing_bldgs_df], how="diagonal_relaxed") | ||
| upgrade = upgrade.sort("bldg_id") | ||
| upgrade = add_saving_cols(upgrade, base) |
There was a problem hiding this comment.
I think this needs to be called on the baseline DF as well so that that schemas for baseline and upgrade files are the same. Even though the savings will be zero, this is easier for users.
There was a problem hiding this comment.
We can do that change in another PR - there are bunch of other column changes we need to do as well.
Revert back to develop branch.
Pull Request Description
Currently, if there are failures in any building in any upgrades, we remove those buildings from all upgrades. This was fine when the failure rate was extremely small, but when failure is substantial, this unnecessarily removes perfectly good buildings from other upgrades just because of one "bad" upgrade. This PR changes the logic so that only the failures in baseline is removed from all upgrades. Failures in upgrades are treated as if the upgrade didn't apply, and we copy baseline results for that building. This approach also aligns with what is done in ComStock.
Related Pull Requests
NatLabRockies/buildstockbatch#513
Related Issues
[What issue(s) is the PR addressing]
Checklist
Required:
Optional (not all items may apply):
openstudio tasks.rb update_measureshas been run