Fix tests and Docker rebuild due to defunct Schemathesis and pytest dependencies resolution #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osma
reviewed
Feb 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #767 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 89 89
Lines 6404 6404
=======================================
Hits 6383 6383
Misses 21 21 ☔ View full report in Codecov by Sentry. |
8fae834 to
07b60b8
Compare
07b60b8 to
a23e18b
Compare
|
|
FYI. I am going to add Pytest 8.0 support in Schemathesis soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pytest 8.0.0 was released on 2014-01-17. Lately Schemathesis releases have been pinning pytest to <=8, and as Poetry favored pytest over Schemathesis in version resolution, pytest 8 and Schemathesis 3.14.2 (version just before pytest <=8 pinning) are now being installed.
The problem is that tests (and thus Docker rebuild) do not work with this ancient Schemathesis version:
This is fixed by pinning to pytest 7.*.* in Annif.