Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@juhoinkinen
Copy link
Member

@juhoinkinen juhoinkinen commented Apr 12, 2024

Continuation to #771.

Also makes requests a regular dependency instead of a test dependency, because the HTTP backend imports requests, so requests needs to be always installed.

@juhoinkinen juhoinkinen added the dependencies Pull requests that update a dependency file label Apr 12, 2024
@codecov
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (3860f84) to head (7eba7ba).
Report is 76 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #786      +/-   ##
==========================================
- Coverage   99.65%   99.64%   -0.02%     
==========================================
  Files          89       91       +2     
  Lines        6405     6768     +363     
==========================================
+ Hits         6383     6744     +361     
- Misses         22       24       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juhoinkinen
Copy link
Member Author

Also SciPy v1.13.0 has been relesased, and we could update to it from v1.12, but there is a breaking change

  • scipy.linalg.tri{,u,l} have been removed in favour of numpy.tri{,u,l}

which affects Gensim. Fortunately they have already fixed this in their development branch, and hopefully there will soon be a release to include the fix.

@juhoinkinen juhoinkinen added this to the 1.1 milestone Apr 12, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@juhoinkinen juhoinkinen marked this pull request as ready for review April 25, 2024 11:55
Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juhoinkinen juhoinkinen merged commit 545662a into main Apr 25, 2024
@juhoinkinen juhoinkinen deleted the update-dependencies-v1.1-round-2 branch April 25, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants