Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Separate vocabulary and language menus and detect language of text #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juhoinkinen merged 59 commits into from
Mar 17, 2025
Merged

Separate vocabulary and language menus and detect language of text #21

juhoinkinen merged 59 commits into from
Mar 17, 2025

Conversation

@juhoinkinen
Copy link
Member

@juhoinkinen juhoinkinen commented Oct 30, 2024 •
edited
Loading

This changes the first menu from "Vocabulary and text language" (Annif project) to "Vocabulary" and adds a menu "Text language" (the Annif project is selected as a combination of the selected vocabulary and language). Thus, the text language can be selected independently of the vocabulary; when a vocabulary is selected, that does not have Annif projects for some languages, those language items are disabled in the languages menu.

Also adds automatic language detection, which updates the selection in the language menu. The language detection is run when

  • a file or url is inputted
  • a user alters text in the textarea and there is >= 10 characters in the text; there is a delay of 1 second

This PR branch is based on the branch of PR #18, so it's better to merge that to main before this. Closes #9.

@juhoinkinen juhoinkinen added the enhancement New feature or request label Oct 30, 2024
@juhoinkinen juhoinkinen mentioned this pull request Oct 30, 2024
Merged
@juhoinkinen juhoinkinen mentioned this pull request Nov 12, 2024
Open
@juhoinkinen
Disable en and sv from text languages menu when KAUNO project is sele…
321b61d 
…cted
@juhoinkinen
Store entire project object in selected_project instead of project_id
5ee6663
@juhoinkinen
Make common vocabularyMixin class(?) with computed vocabularyId() fun…
fa57893 
…ction
@juhoinkinen
Fix labels language selecting
65a8652
@juhoinkinen
Make vocabulary menu functional
14850fc
@juhoinkinen
Use detected language to select project for suggest request
123ac09
@juhoinkinen
Remove unnecessary vocabularyId definition method as it is provided b…
3efab74 
…y mixin
@juhoinkinen
Fix forgotten variable rename
a05faaa
@juhoinkinen
Remove unused variable selected_project
de5e577
@juhoinkinen
Remove unnecessary vocabularyMixin
83508cd
@juhoinkinen
wip Turn Text language menu to buttons
d28a830
@juhoinkinen
Swap order of text selection boxes and checkbox
7cd013e
@juhoinkinen
Detect language of text on file and url inputs to textarea
5d4999f
@juhoinkinen
Trigger language detection on typing to textarea with 1 sec delay
3bd8b32
@juhoinkinen
Make checkbox for disabling auto lang detect functional
5791c2f
@juhoinkinen
Refactor: use common reading_effects function
2a605ee
@juhoinkinen
Show alert for failed language detection
e43e62b
@juhoinkinen
Fix/add hover effect to selector and copy buttons
040ab17
@juhoinkinen
Remove now unnecessary explanation text from front of vocabulary name
d1f41db
@juhoinkinen
Better variable name
e710011
@juhoinkinen
Drop language names from vocab menu items
c908f92
@juhoinkinen juhoinkinen marked this pull request as ready for review January 13, 2025 07:23
@juhoinkinen juhoinkinen changed the title Detect language of text Separate vocabulary and language menus and detect language of text Jan 13, 2025
@osma osma self-requested a review February 3, 2025 08:28
@juhoinkinen juhoinkinen changed the base branch from update-2024 to main February 6, 2025 13:49
@osma osma mentioned this pull request Mar 6, 2025
Closed
osma
osma requested changes Mar 6, 2025
View reviewed changes
Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, I left a few comments and suggestions.

juhoinkinen and others added 10 commits March 6, 2025 15:55
@juhoinkinen
Copy link
Member Author

juhoinkinen commented Mar 17, 2025

All requested changes have been addressed, I merge this.

@juhoinkinen juhoinkinen merged commit aa05c02 into main Mar 17, 2025
@osma osma mentioned this pull request Mar 21, 2025
Merged
@juhoinkinen juhoinkinen deleted the issue9-detect-language-of-text branch March 21, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osma osma osma requested changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Detect language of text

3 participants

@juhoinkinen @osma