use vendor cacert.pem for custom binaries #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively we could search both locations for a |
|
@NativePHP/contributors one more review to push this through 👀 |
simonhamp
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using custom PHP binaries the
CopiesCertificateAuthoritytrait would look for thecacert.pemfile relative to the custom binary path.It's not documented that users should provider their own certificate bundle in this case. I see no reason why we should not use the default certs used by
php-bin. Since we include the repo by default it should always be there & be updated.This PR removes the conditional & makes sure the certs in
vendor/nativephp/php-bin/cacert.pemare always used.Fixes: NativePHP/laravel#655