Environment Helper #527
Merged
Environment Helper #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The addition of the Environment class helper allows us to provide known ways of identifying things in the environment which may affect workflows dependent on the system NativePHP is running on. To begin with, I have added the Operating Systems and this demonstrates how now we can use one point of truth without many different methods of checking for the same result. This can be extended out as needs emerge. |
SRWieZ
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on refactoring the code to use a new
Environmentclass for determining the operating system, improving readability and maintainability. The most important changes include the introduction of theEnvironmentclass and its integration into existing methods.Introduction of the
Environmentclass:src/Support/Environment.php: Added a newEnvironmentclass with methods to check the current operating system (isWindows,isLinux,isMac,isUnknown,isUnixLike).Integration of the
Environmentclass:src/Commands/DebugCommand.php: Replaced checks forPHP_OS_FAMILYwith calls to the newEnvironmentclass methods inprocessEnvironmentandoutputToClipboardfunctions. [1] [2]src/System.php: Updated thetimezonefunction to useEnvironment::isWindowsinstead of checkingPHP_OS_FAMILY.Additional updates to import the
Environmentclass:src/Commands/DebugCommand.php: Added import forNative\Laravel\Support\Environment.src/System.php: Added import forNative\Laravel\Support\Environment.