V2 #698
V2 #698
Conversation
* Fix killing process * Fix killing process * Stopping persistent process and fix restarting process spawning twice * Stopping persistent process and fix restarting process spawning twice * Fix process being briefly restarted on quitting
* Fix powerMonitor events * compiled js * Fix powerMonitor events
* Code style * Fix variable name * Add tooltip support * Add resizable option * Add icon change support * Preload window for UX * Add standard window preload script This makes the menubar window work just like other windows * Support custom event on click
Co-authored-by: Justin Lawrence <[email protected]>
* Prevent double-registration * Don't activate on dock icon click * Always send right-click event
* remove commented env merge * fix typo * forward native env variables to child process * Build plugin * Update resources/js/electron-plugin/src/server/api/childProcess.ts Co-authored-by: Simon Hamp <[email protected]> * Build plugin * add php endpoint with native env variables * extract defaultPhpIniSettings function * mix in php ini settings * boyscouting - cleanup startQueueWorker * Build plugin * Code style * merge defaults with user configured ini settings * Build plugin * tidy * Build plugin --------- Co-authored-by: Simon Hamp <[email protected]>
|
The Next steps are a thorough refactor round to improve some of the papercuts that were caused by having this as two separate packages before. I think we can clean a couple things up 💅🏻 |
this was not possible before because the test logic lived in another repo than the config
was disabled because of 'prefer-lowest' matrix issues when the config was living in the other repo before
|
Both packages are merged. Everything looks good Next up: publish the electron project into the userland project under I'll address that in a separate PR. For now can I get a review on this? As mentioned before, these PR's are already merged in here to avoid issues later on. (I'm not merging those with main in case we need to hotfix)
Most of this PR is straight forward. Mostly moving things around & fixing paths. Are there any architectural changes you think make sense now we're at it? |
|
Obviously is hard to review that many of changes but
|
composer.json
Outdated
| ], | ||
| "conflict": { | ||
| "nativephp/mobile": "*", | ||
| "nativephp/laravel": "*", |
There was a problem hiding this comment.
I added the old packages as well as the mobile package as a conflicting dependency
There was a problem hiding this comment.
I removed the Laravel package. It caused an error on packagist
This pull request introduces significant updates to unify Electron & Laravel packages under the same repo
I've kept the git history from the electron repo around, so you'll see a lot of commits here. Maybe not easy to review, but good for discovery when debugging later on.
These PR's to main are already merged in this branch:
v38electron#252Package rename
The package has been renamed to
nativephp/desktopNew structure
The new structure is as follows:
All workflows and other necessities have also been migrated over to the Laravel repo.