Thanks to visit codestin.com
Credit goes to github.com

Skip to content

v2-refactor #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: v2
Choose a base branch
from
Open

v2-refactor #700

wants to merge 13 commits into from

Conversation

gwleuverink
Copy link
Contributor

This PR moves all of the code that does not directly involve Electron from the Electron to the Support namespace.

  • Several traits and methods previously spread across commands are now encapsulated within the Native\Support\Bundler class.
  • Additionally I added a native:install script to post-update-cmd automatically.

There is room for improvement, but incrementally I think this is a good first step.

Appreciate any thoughts on this!

@gwleuverink
Copy link
Contributor Author

gwleuverink commented Sep 25, 2025 •
edited
Loading

I discussed this with @SRWieZ. We concluded that it is better to put everything under the Desktop namespace.

I updated the PR to use this structure:

/
└── src
    ├── NativeServiceProvider.php
    ├── ... etc
    ├── Builder
    │   ├── Builder.php
    │   └── ...
    └── Drivers
        └── Electron
            ├── ElectronServiceProvider.php
            └── ...

The old Electron package now lives in Native\Desktop\Drivers\Electron

The Builder related traits I mentioned moved to the Native\Desktop\Builder class.

@gwleuverink gwleuverink requested a review from a team September 25, 2025 13:02
@gwleuverink gwleuverink marked this pull request as ready for review September 26, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gwleuverink