fix(core): .ns-light and .ns-dark doesn't apply through to dialogs #10201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When triggering alert() or dialogs.confirm (from @nativescript/core/ui/dialogs), the button color is expected to follow the style of "Button" type selector defined on the css.
It works fine, however, when .ns-light or .ns-dark identifier is added in front of "Button" or "Label", it is not recognizable and does not take effect.
Please see the app.scss file below:
before-bugfix.mov
There're open issues for this same bug:
What is the new behavior?
The css style is being applied properly.
after-bugfix.mov