fix(ios/background): Fix background clear #10415
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanWalker
approved these changes
Oct 19, 2023
|
Thank you @PeterStaev we'll kick off CI tests after the other pending PR clears. |
|
@PeterStaev This has been fixed and enhanced by #10404 #10409. Please retry with latest repo changes. |
|
@CatchABus I can confirm that the |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Right now seems it can happen that the
layerof the background ends up undefined in some situations. As an example I have a view with List that navigates to a page with a BottomNavigation. When navigating back to the list thelayerends up undefined and the app crashes.What is the new behavior?
Adds a safety check before trying to reset the layer's mask thus resolving the crash.
Fixes/Implements/Closes #[Issue Number].