Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: prevent breaking modal stack #10557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2024
Merged

fix: prevent breaking modal stack #10557

merged 1 commit into from
Jun 16, 2024

Conversation

farfromrefug
Copy link
Collaborator

Using splice without second parameter was removing all elements after first argument index. This would break if a modal was closed just after opening a second one.
You would also end up with views (the modal ones) in an "undead" state

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

Using splice without second parameter was removing all elements after first argument index.
This would break if a modal was closed just after opening a second one
@cla-bot cla-bot bot added the cla: yes label May 29, 2024
@NathanWalker NathanWalker merged commit 84e1a67 into main Jun 16, 2024
4 checks passed
@NathanWalker NathanWalker deleted the farfromrefug-patch-3 branch June 16, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants