Thanks to visit codestin.com
Credit goes to github.com

fix(android): RootLayout shade cover null color handling #10599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

NathanWalker merged 2 commits into NativeScript:main from CatchABus:root-layout-fix

Aug 5, 2024

Contributor

CatchABus commented Aug 5, 2024

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

When Android RootLayout shade cover color is null, it results in unhandled exception.

What is the new behavior?

Added null checks for android shade cover color.


          fix(android): RootLayout shade cover null color handling

e344ea3

cla-bot bot added the cla: yes label

NathanWalker approved these changes

View reviewed changes


          Merge branch 'main' into root-layout-fix

dd1c28b

NathanWalker merged commit f7b9d06 into NativeScript:main

1 of 4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels