Thanks to visit codestin.com
Credit goes to github.com

fix(layout): prevent negative width/height values #10616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

NathanWalker merged 1 commit into main from fix/layout-negative-width-bug

Sep 3, 2024

Member

rigor789 commented Sep 3, 2024

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

In some cases a negative width/height can happen, when the child width is 0, but the margins are subtracted from it.

What is the new behavior?

The width/height should never go negative.

Fixes/Implements/Closes #[Issue Number].


          fix(layout): prevent negative width/height values

f5eed00

NathanWalker approved these changes

View reviewed changes

NathanWalker merged commit 0506012 into main

1 of 3 checks passed

NathanWalker deleted the fix/layout-negative-width-bug branch

September 3, 2024 15:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet