Thanks to visit codestin.com
Credit goes to github.com

fix: circular imports #10670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

NathanWalker merged 1 commit into NativeScript:feat/napi from ammarahm-ed:fix-circular-imports

Jan 19, 2025

Contributor

ammarahm-ed commented Jan 19, 2025 •

edited

Loading

JSC fails to run a basic NativeScript add due to these imports, probably a circular.

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

What is the new behavior?


          fix: circular imports

JSC fails to run a basic NativeScript add due to these imports,  probably a circular.

NathanWalker changed the base branch from main to feat/napi

January 19, 2025 19:31

NathanWalker merged commit 2afed08 into NativeScript:feat/napi

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet