Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(android): RootLayout shade cover blinking animation #10750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 26, 2025
Merged

fix(android): RootLayout shade cover blinking animation #10750

merged 4 commits into from
Jun 26, 2025

Conversation

CatchABus
Copy link
Contributor

@CatchABus CatchABus commented Jun 26, 2025 •
edited by coderabbitai bot
Loading

PR Checklist

What is the current behavior?

On android, RootLayout shade cover has a strange dark blinking on shade animation start.
That is because we enforce a default color in cases when color shouldn't be animated (init and close).

What is the new behavior?

This PR makes sure that RootLayout will animate shade cover color only when needed.
As for default shade color, it's already set on a previous step so it doesn't break.

Summary by CodeRabbit

  • Bug Fixes
    • Improved animation handling to prevent unnecessary background color animations when no background color is specified.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 26, 2025 •
edited
Loading

Walkthrough

The _getAnimationSet method in the RootLayout class was updated to make the backgroundColor parameter optional. The logic for determining the animation set array's length and the assignment of the background color animator was adjusted to account for cases where backgroundColor is undefined or a gradient.

Changes

File(s) Change Summary
packages/core/ui/layouts/root-layout/index.android.ts Made backgroundColor optional in _getAnimationSet; updated logic for array sizing and background animator usage.

Poem

A hop and a skip, a background anew,
Now colors can fade or simply not show through.
With options more open, the code feels just right,
Animations now dance from morning to night.
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-26T15_42_33_648Z-debug-0.log

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 26, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit a8c8466.

Command Status Duration Result
nx test apps-automated -c=ios ✅ Succeeded 2m 16s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-26 19:10:10 UTC

@CatchABus CatchABus marked this pull request as draft June 26, 2025 15:43
coderabbitai[bot]
coderabbitai bot reviewed Jun 26, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/core/ui/layouts/root-layout/index.android.ts (1)

101-103: Conditional assignment prevents unwanted background color animation.

The conditional check correctly prevents the background color animator from being created when backgroundColor is undefined, which eliminates the blinking effect.

Consider applying the static analysis suggestion to use optional chaining on line 80:

-		const isBackgroundGradient = backgroundColor && backgroundColor.startsWith('linear-gradient');
+		const isBackgroundGradient = backgroundColor?.startsWith('linear-gradient');
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 69ba9b7 and 1781771.

📒 Files selected for processing (1)
  • packages/core/ui/layouts/root-layout/index.android.ts (2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
packages/core/ui/layouts/root-layout/index.android.ts (2)
packages/core/ui/core/view/index.android.ts (1)
  • View (317-1268)
packages/core/ui/layouts/root-layout/index.d.ts (1)
  • TransitionAnimation (40-49)
🪛 Biome (1.9.4)
packages/core/ui/layouts/root-layout/index.android.ts

[error] 80-80: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: test-ios
  • GitHub Check: test-android
🔇 Additional comments (2)
packages/core/ui/layouts/root-layout/index.android.ts (2)

79-79: Good fix for preventing unwanted background color animations!

Making the backgroundColor parameter optional instead of having a default value correctly addresses the blinking issue. This ensures background color animation only occurs when explicitly requested, preventing the unwanted blinking effect during initialization and closing phases.

82-82: Correct array sizing logic for optional backgroundColor.

The updated logic properly sizes the animation array based on whether a background color animator will be included. When backgroundColor is undefined or it's a gradient, the array size is 6; otherwise it's 7.

@CatchABus CatchABus marked this pull request as ready for review June 26, 2025 15:51
@NathanWalker NathanWalker merged commit 242c3ae into NativeScript:main Jun 26, 2025
4 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jun 28, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@NathanWalker NathanWalker NathanWalker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CatchABus @NathanWalker