Thanks to visit codestin.com
Credit goes to github.com

Skip to content

5620 GridLayout addChild to set row and column #6411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 19, 2018
Merged

5620 GridLayout addChild to set row and column #6411

merged 6 commits into from
Oct 19, 2018

Conversation

rakeshgirase
Copy link
Contributor

@rakeshgirase rakeshgirase commented Oct 13, 2018 •
edited
Loading

PR Checklist

What is the current behavior?

Current GridLayout do not provide a function to add a view at a cell so as per issue 5620 you need 4 lines to add a view to a Grid Layout with row, column, rowSpan and columnSpan.

What is the new behavior?

If this PR is accepted then the view can be added at a cell with rowSpan and columnSpan in a single line code.

Fixes/Implements/Closes #[Issue Number].
Fixes #5620

@ghost ghost added the ♥ community PR label Oct 13, 2018
@rakeshgirase rakeshgirase mentioned this pull request Oct 13, 2018
Closed
@vakrilov
Copy link
Contributor

test

@vakrilov
Copy link
Contributor

Thanks for the PR @rakeshgirase!

Code looks good - I have triggered the CI to see if all is green.
On a sidenote: In future, please make sure you follow the commit-messages guidelines.

@rakeshgirase
Copy link
Contributor Author

Thanks for the PR @rakeshgirase!

Code looks good - I have triggered the CI to see if all is green.
On a sidenote: In future, please make sure you follow the commit-messages guidelines.

Sure @vakrilov . Sorry I missed it.

@ghost ghost assigned SvetoslavTsenov Oct 15, 2018
@ghost ghost added in progress and removed ♥ community PR labels Oct 15, 2018
@vakrilov
Copy link
Contributor

vakrilov commented Oct 17, 2018 •
edited
Loading

Hey @rakeshgirase - thanks again for the PR!
We are currently in a code-freeze phase for the NativeScript 5.0 release. This means, it might take more time to merge PRs into master.

We will notify you if the is some action needed form your side.
Thanks for understanding and being awesome part of the NS community!

@ghost ghost assigned vakrilov Oct 18, 2018
@vakrilov
Copy link
Contributor

test

@vakrilov vakrilov merged commit a3f1493 into NativeScript:master Oct 19, 2018
@ghost ghost removed the in progress label Oct 19, 2018
@radeva
Copy link

radeva commented Nov 19, 2018

Hi @rakeshgirase ,

Congratulations on being one of the winners in the {N} First-time contributors contest!

You can claim your prize by contacting us at nativescriptwinners[at]progress.com not later than Nov 30th 2018 . Make sure you send us the following info: 
👉Your full name 
👉Your email 
👉Your country or residence 

Best regards,
The NativeScript Team

@lock
Copy link

lock bot commented Nov 19, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vakrilov vakrilov vakrilov approved these changes

Assignees

@SvetoslavTsenov SvetoslavTsenov

@vakrilov vakrilov

Labels
cla: yes ♥ community PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] GridLayout's addChild method to take care of setting row and column
5 participants
@rakeshgirase @vakrilov @radeva @SvetoslavTsenov @ns-bot