Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix-next(android): popExit fragment animation #6421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2018
Merged

fix-next(android): popExit fragment animation #6421

merged 1 commit into from
Oct 26, 2018

Conversation

manoldonev
Copy link
Contributor

@manoldonev manoldonev commented Oct 16, 2018 •
edited
Loading

Fix issues with "popExit" fragment animation when FragmentTransaction.setCustomAnimations(...) are used.
Also reworked fix from #6339

Kudos to @MartoYankov for the assistance! 👍

@manoldonev manoldonev self-assigned this Oct 16, 2018
@ghost ghost added the in progress label Oct 16, 2018
@manoldonev manoldonev changed the title fix-next(android): exit fragment animation [WIP] fix-next(android): exit fragment animation Oct 17, 2018
@manoldonev manoldonev force-pushed the mdonev/fragment-exit-animation-fix branch from 158621e to effa137 Compare October 25, 2018 17:21
@manoldonev manoldonev changed the title [WIP] fix-next(android): exit fragment animation [WIP] fix-next(android): popExit fragment animation Oct 25, 2018
@manoldonev manoldonev force-pushed the mdonev/fragment-exit-animation-fix branch 2 times, most recently from a353c1d to b27d370 Compare October 25, 2018 17:44
@manoldonev manoldonev changed the title [WIP] fix-next(android): popExit fragment animation fix-next(android): popExit fragment animation Oct 25, 2018
@manoldonev manoldonev force-pushed the mdonev/fragment-exit-animation-fix branch from b27d370 to 3e1b086 Compare October 26, 2018 08:10
@manoldonev
Copy link
Contributor Author

test tests_app_transitions animations

@SvetoslavTsenov
Copy link
Contributor

test ignore tests_app_transitions animations api19 api 21 api23

@SvetoslavTsenov
Copy link
Contributor

test --ignore tests_app_transitions animations api19 api 21 api23

@SvetoslavTsenov
Copy link
Contributor

test --ignore tests_app_transitions animations api19 api21 api22 api23

@manoldonev manoldonev merged commit 4765dd9 into master Oct 26, 2018
@manoldonev manoldonev deleted the mdonev/fragment-exit-animation-fix branch October 26, 2018 10:32
@ghost ghost removed the in progress label Oct 26, 2018
@manoldonev manoldonev mentioned this pull request Oct 26, 2018
Merged
dtopuzov pushed a commit that referenced this pull request Oct 29, 2018
@manoldonev @dtopuzov
fix-next(android): exit fragment animation (#6421)
c217f12
@manoldonev manoldonev mentioned this pull request Nov 2, 2018
Merged
@lock
Copy link

lock bot commented Oct 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vakrilov vakrilov vakrilov approved these changes

@ADjenkov ADjenkov Awaiting requested review from ADjenkov

@MartoYankov MartoYankov Awaiting requested review from MartoYankov

@vchimev vchimev Awaiting requested review from vchimev

@SvetoslavTsenov SvetoslavTsenov Awaiting requested review from SvetoslavTsenov

Assignees

@manoldonev manoldonev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manoldonev @SvetoslavTsenov @vakrilov @ns-bot