Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix-next(android): restore fade animation for simulated nav #6463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2018

Conversation

manoldonev
Copy link
Contributor

Restore animation (default fade) for simulated first navigation that was removed with #6421.

Reason is that without animation the flickering when navigating between bottom-positioned tabs in a TabView is even more pronounced than with the fade animation (eventually we should fix the flicker altogether).

@manoldonev manoldonev self-assigned this Oct 26, 2018
@ghost ghost added the in progress label Oct 26, 2018
@manoldonev
Copy link
Contributor Author

test --ignore tests_app_transitions animations api19 api21 api22 api23

@manoldonev manoldonev merged commit 448936d into master Oct 26, 2018
@ghost ghost removed the in progress label Oct 26, 2018
@manoldonev manoldonev deleted the mdonev/default-fade-for-sim-navigation-fix branch October 26, 2018 14:09
manoldonev added a commit that referenced this pull request Oct 29, 2018
manoldonev added a commit that referenced this pull request Oct 29, 2018
dtopuzov pushed a commit that referenced this pull request Oct 29, 2018
@lock
Copy link

lock bot commented Oct 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants