Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(android): Request Timeout #6523 #8194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2020

Conversation

SpurguX
Copy link
Contributor

@SpurguX SpurguX commented Dec 13, 2019

Fix http requests to use read timeout in addition to connect timeout.

PR Checklist

What is the current behavior?

Http timeout doesn't work as expected #6523 . When timeout is set, the request times out only if connection is not established within the timeout threshold.

What is the new behavior?

When timeout is set, the request will time out when the request has not completed within the timeout threshold. This can be due to failed connection or a response that takes too long to finish.
Fixes/Implements/Closes #6523 .

WIP - Writing Tests

I'm not sure how I should proceed with regard to writing the tests for a few reasons:

  • In what module should I write the test(s)? http?
  • I don't have an iOS device to test with.
  • To test that a request connects but then fails due to not completing would require some stable URL whose response takes at least a set amount of time.

Fix http requests to use read timeout in addition to connect timeout.
@cla-bot
Copy link

cla-bot bot commented Dec 13, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jesse Taina.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@vtrifonov vtrifonov marked this pull request as ready for review December 19, 2019 12:43
@vtrifonov
Copy link
Contributor

@SpurguX thanks for your contribution! Could you sign the CLA, please!

@cla-bot cla-bot bot added the cla: yes label Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http timeout seems not to work
5 participants