feat(html-view): Additional properties for HtmlView component #8207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow to set text color with `color` CSS property. - Allow to set link color with `link-color` CSS property. - Allow to set font attributes with `font-family` and `font-size` CSS properties. - Make text selectable on Android by default (for consistency with IOS). - Remove extra padding on IOS.
vtrifonov
suggested changes
Jan 6, 2020
| } from "./html-view-common"; | ||
| import { ios } from "../../utils/utils"; | ||
|
|
||
| export * from "./html-view-common"; | ||
|
|
||
| const majorVersion = ios.MajorVersion; | ||
|
|
||
| function uiColorToHex(uiColor: UIColor): string { |
There was a problem hiding this comment.
It would be better if you move the function in the nativescript-core/color/color-common.ts file and use it from there, as it seems like something that can be used in other places as well.
There was a problem hiding this comment.
I made it a static method in Color class.
vtrifonov
approved these changes
Jan 7, 2020
|
@xuhcc I've added the new properties in the e2e test by committing directly in your branch |
This was referenced Mar 20, 2020
This was referenced Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
What is the new behavior?
colorCSS property.link-colorCSS property.font-familyandfont-sizeCSS properties.Implements #1266
Related: #1268 #4358 #4746
BREAKING CHANGES:
The appearance of
HtmlViewcomponent may change in existing apps.