Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(core): RootLayout option with api to fluidly handle dynamic layers #8980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

williamjuan027
Copy link
Member

@williamjuan027 williamjuan027 commented Oct 22, 2020

PR Checklist

What is the current behavior?

Write a bunch of frontend framework flavor code to handle dynamic layers.

What is the new behavior?

Take advantage of unified api to easily spawn layered views with animation controls and modify their zOrder/front/back with ease which works in all flavors without additional code.
For more context see from here onward (example walkthrough of similar techniques specific to angular however this PR boils down all complexity to elegant approach in core for all flavors to take advantage of similar creative view handling): https://youtu.be/khHtbeTLRMM?t=992

root-layout

@cla-bot
Copy link

cla-bot bot commented Oct 22, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @williamjuan027.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@williamjuan027
Copy link
Member Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Oct 22, 2020
@cla-bot
Copy link

cla-bot bot commented Oct 22, 2020

The cla-bot has been summoned, and re-checked this pull request!

@NathanWalker NathanWalker added this to the 8.0 milestone Oct 27, 2020
@NathanWalker NathanWalker added the ready for test TSC needs to test this and confirm against live production apps and automated test suites label Nov 16, 2020
@NathanWalker NathanWalker changed the base branch from master to release/8.0.0 January 21, 2021 17:33
@NathanWalker NathanWalker merged commit ba9a8df into NativeScript:release/8.0.0 Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready for test TSC needs to test this and confirm against live production apps and automated test suites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants