Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: TextField issue with vietnamese keyboard layout on iOS #9037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ngocnt1
Copy link

@ngocnt1 ngocnt1 commented Nov 14, 2020

PR Checklist

What is the current behavior?

See details in #8446

What is the new behavior?

works as expected, see details in #8446

Fixes/Implements/Closes #8446.

@cla-bot cla-bot bot added the cla: yes label Nov 14, 2020
@ngocnt1 ngocnt1 changed the title feat: TextField issue with vietnamese input on iOS feat: TextField issue with vietnamese keyboard layout on iOS Nov 14, 2020
@NathanWalker NathanWalker added the ready for test TSC needs to test this and confirm against live production apps and automated test suites label Nov 16, 2020
@rigor789
Copy link
Member

this.updateTextTrigger refers to the Property defined on EditableTextBase. The default value is textChanged, but perhaps you would need to set it to focusLost in your code and that'd be enough?

I'm worried about side effects of this change - textChanged is already handled elsewhere, and this looks like it would potentially fire the nativeValueChange twice in some cases.

We'll have to do a bit more testing around this to make sure.

@ngocnt1
Copy link
Author

ngocnt1 commented Dec 20, 2020

@rigor789
i don't see focusLost in https://docs.nativescript.org/angular/ui/ng-components/text-field#events, but i tried blur, it didn't help.
i published this PR on my latest app release: https://apps.apple.com/vn/app/money-note/id1487378110
so far so good.
my app is multilangual

@rigor789
Copy link
Member

<TextField updateTextTrigger="focusLost"/>

Is what I meant, it's the value that's being read in:

if (this.updateTextTrigger === 'focusLost') {

@ngocnt1
Copy link
Author

ngocnt1 commented Jan 19, 2021

<TextField updateTextTrigger="focusLost"/>

Is what I meant, it's the value that's being read in:

if (this.updateTextTrigger === 'focusLost') {

if so, we have to add that "updateTextTrigger" attribute for case by case, i don't think it help to fix the root issue. Vietnamese keylayout was added to MacOS,iOS, Windows,
Do you find any impacts from your testing?

@cla-bot
Copy link

cla-bot bot commented Aug 11, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @ngocnt1.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for test TSC needs to test this and confirm against live production apps and automated test suites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextField issue with vietnamese input on iOS
3 participants