fix(android): refactor to make less calls to native #9119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanaelA
suggested changes
Dec 30, 2020
| @@ -860,30 +863,32 @@ export class View extends ViewCommon { | |||
| [horizontalAlignmentProperty.setNative](value: HorizontalAlignment) { | |||
| const nativeView = this.nativeViewProtected; | |||
| const lp: any = nativeView.getLayoutParams() || new org.nativescript.widgets.CommonLayoutParams(); | |||
| const gravity = lp.gravity; | |||
| const weight = lp.weight; | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
There was a problem hiding this comment.
In fact I would not. I forgot a if lp.gravity which makes 2 calls to native accesser. Need to fix this. The idea is to make sure we don't access those native variables multiple times => multiple jni calls
| @@ -898,30 +903,32 @@ export class View extends ViewCommon { | |||
| [verticalAlignmentProperty.setNative](value: VerticalAlignment) { | |||
| const nativeView = this.nativeViewProtected; | |||
| const lp: any = nativeView.getLayoutParams() || new org.nativescript.widgets.CommonLayoutParams(); | |||
| const gravity = lp.gravity; | |||
| const height = lp.height; | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| // Set only if params gravity exists. | ||
| if (lp.gravity !== undefined) { | ||
| switch (value) { | ||
| case 'left': | ||
| lp.gravity = android.view.Gravity.LEFT | (lp.gravity & android.view.Gravity.VERTICAL_GRAVITY_MASK); | ||
| if (lp.weight < 0) { | ||
| lp.gravity = 3 | (gravity & VERTICAL_GRAVITY_MASK); // android.view.Gravity.LEFT |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
There was a problem hiding this comment.
I remember i copied the way it was done somewhere else. And I didn't want to unecessarly create global module variables.
But sure I ll change it
NathanWalker
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the android code a bit to make less calls to android native constants. Thus less JNI bridge calls =>faster