Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: onSaveInstanceState should not crash when no rootView is set #9447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2021

Conversation

edusperoni
Copy link
Contributor

PR Checklist

What is the current behavior?

On an edge case where the rootView is not set, onSaveInstanceState will crash the app.

What is the new behavior?

No longer crashes as we check if the rootView exists before using it.

Fixes NativeScript/angular#8.

@cla-bot cla-bot bot added the cla: yes label Jun 16, 2021
@edusperoni edusperoni requested a review from NathanWalker June 16, 2021 16:47
rigor789
rigor789 previously approved these changes Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property '_domId' of undefined after upgrading to Angular 12
3 participants