Thanks to visit codestin.com
Credit goes to github.com

Skip to content

svelte changes from halfnelson #9497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

farfromrefug
Copy link
Collaborator

I think this should do it from what he did

@cla-bot
Copy link

cla-bot bot commented Aug 4, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @halfnelson.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@farfromrefug
Copy link
Collaborator Author

@rigor789 why is the bot asking for @halfnelson cla ...

@cla-bot
Copy link

cla-bot bot commented Aug 4, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @halfnelson.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@rigor789 rigor789 merged commit 59d9271 into NativeScript:master Aug 11, 2021
@farfromrefug farfromrefug deleted the pullrequests/halfnelson/feat/webpack5 branch August 11, 2021 09:55
rigor789 added a commit that referenced this pull request Sep 7, 2021
* update svelte config to use svelte-loader

* handle null config

* fix: worker support in .svelte files & update snapshots

* fix after merge

Co-authored-by: halfnelson <[email protected]>
Co-authored-by: Igor Randjelovic <[email protected]>
rigor789 added a commit that referenced this pull request Sep 7, 2021
* feat: Frame replacePage by entry

* feat(webpack): improved svelte HMR (#9497)

* update svelte config to use svelte-loader

* handle null config

* fix: worker support in .svelte files & update snapshots

* fix after merge

Co-authored-by: halfnelson <[email protected]>
Co-authored-by: Igor Randjelovic <[email protected]>

* feat(webpack): use svelte-loader and fallback to svelte-loader-hot

Allows running older projects

* feat: allow overwriting replacePage transition

Co-authored-by: farfromrefuge <[email protected]>
Co-authored-by: halfnelson <[email protected]>
NathanWalker pushed a commit that referenced this pull request Sep 8, 2021
* feat: Frame replacePage by entry

* feat(webpack): improved svelte HMR (#9497)

* update svelte config to use svelte-loader

* handle null config

* fix: worker support in .svelte files & update snapshots

* fix after merge

Co-authored-by: halfnelson <[email protected]>
Co-authored-by: Igor Randjelovic <[email protected]>

* feat(webpack): use svelte-loader and fallback to svelte-loader-hot

Allows running older projects

* feat: allow overwriting replacePage transition

Co-authored-by: farfromrefuge <[email protected]>
Co-authored-by: halfnelson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants