Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(android): do not call exitEvent on activity restart #9517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2021
Merged

fix(android): do not call exitEvent on activity restart #9517

merged 1 commit into from
Aug 18, 2021

Conversation

edusperoni
Copy link
Contributor

PR Checklist

What is the current behavior?

After changing the system theme (toggle dark mode)

JS: activityPaused
JS: activityStopped
JS: saveActivityState
JS: [exitEvent] // this destroys the angular instance, probably the same for other flavors
JS: activityDestroyed
JS: activityCreated
JS: activityStarted
JS: activityResumed

normal exit:

JS: activityBackPressed
JS: [suspendEvent]
JS: activityPaused
JS: activityStopped
JS: [exitEvent]
JS: activityDestroyed

normal enter (after previous exit)

JS: activityCreated
JS: activityNewIntent
JS: [launchEvent] // this creates the angular/other flavors instance

What is the new behavior?

JS: activityPaused
JS: activityStopped
JS: saveActivityState
// no exit event here!
JS: activityDestroyed
JS: activityCreated
JS: activityStarted
JS: activityResumed

Fixes/Implements/Closes #[Issue Number].

@cla-bot cla-bot bot added the cla: yes label Aug 18, 2021
@NathanWalker NathanWalker merged commit 2f630dc into master Aug 18, 2021
@NathanWalker NathanWalker deleted the fix/exit-event branch August 18, 2021 16:09
@edusperoni edusperoni mentioned this pull request Aug 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanWalker NathanWalker NathanWalker approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edusperoni @NathanWalker