-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(core): support RGB alpha notation #9699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NathanWalker
merged 3 commits into
NativeScript:release/8.2.0
from
lekhmanrus:rgb-alpha-notation
Jan 14, 2022
Merged
feat(core): support RGB alpha notation #9699
NathanWalker
merged 3 commits into
NativeScript:release/8.2.0
from
lekhmanrus:rgb-alpha-notation
Jan 14, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ruslan Lekhman.
|
a897334
to
5ab0e77
Compare
NathanWalker
previously approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work 👏
Functional notation: rgb[a](R G B[ / A]) CSS Colors Level 4 adds support for space-separated values in the functional notation. See https://www.w3.org/TR/css-color-4/#rgb-functions
5ab0e77
to
d8f9ca8
Compare
@NathanWalker thanks 😀 |
NathanWalker
approved these changes
Dec 23, 2021
NathanWalker
approved these changes
Jan 14, 2022
NathanWalker
added a commit
that referenced
this pull request
Feb 14, 2022
Functional notation: rgb[a](R G B[ / A]) CSS Colors Level 4 adds support for space-separated values in the functional notation. See https://www.w3.org/TR/css-color-4/#rgb-functions Co-authored-by: Nathan Walker <[email protected]>
NathanWalker
added a commit
that referenced
this pull request
Feb 18, 2022
Functional notation: rgb[a](R G B[ / A]) CSS Colors Level 4 adds support for space-separated values in the functional notation. See https://www.w3.org/TR/css-color-4/#rgb-functions Co-authored-by: Nathan Walker <[email protected]>
NathanWalker
added a commit
that referenced
this pull request
Mar 1, 2022
Functional notation: rgb[a](R G B[ / A]) CSS Colors Level 4 adds support for space-separated values in the functional notation. See https://www.w3.org/TR/css-color-4/#rgb-functions Co-authored-by: Nathan Walker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional notation: rgb[a](R G B[ / A])
CSS Colors Level 4 adds support for space-separated values in the functional notation.
See https://www.w3.org/TR/css-color-4/#rgb-functions
PR Checklist
What is the current behavior?
It parses
rgb(1 2 3 / 4)
as{ f: 1, s: 255, t: 255, a: 255 }
What is the new behavior?
Supports
rgb[a](R G B[ / A])
notation.