fix: androidx fragments 1.3+ #9728

edusperoni · 2022-01-03T20:15:46Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

BREAKING CHANGE: AndroidFragmentCallbacks now requires onResume as well Migration steps: specify onResume on custom fragment implementations

edusperoni · 2022-01-03T20:18:10Z

Todo list:

update .d.ts (type comments are wrong)
test with fragment 1.4+
test with fragment <1.3
revert fix(android): nested frames were sometimes not recreated #9725
document change for plugin developers to implement _getFragment or _getFragmentLifecycle
clear _parentFragment

things to consider:

not a fan of _parentFragment
possible edge case/inconsistent state when fragment gets destroyed before started
that observer may be an issue with markingMode: "none" (the default)

…le file. (#9720)

…recognizers when needed

#9734)

Functional notation: rgb[a](R G B[ / A]) CSS Colors Level 4 adds support for space-separated values in the functional notation. See https://www.w3.org/TR/css-color-4/#rgb-functions Co-authored-by: Nathan Walker <[email protected]>

Co-authored-by: William Juan <[email protected]>

NathanWalker and others added 6 commits December 31, 2021 08:36

chore: ignore local .npmrc

1c79035

fix(android): nested frames were sometimes not recreated (#9725)

72b01c2

BREAKING CHANGE: AndroidFragmentCallbacks now requires onResume as well Migration steps: specify onResume on custom fragment implementations

chore: update workspace dependencies

1b6189b

chore: 8.2.0-alpha.0

37bfb0f

chore: ensure any local .npmrc is never wiped out

089f56d

fix: androidx fragments 1.3+

3cae2c2

cla-bot bot added the cla: yes label Jan 3, 2022

NathanWalker changed the base branch from master to release/8.2.0 January 4, 2022 01:31

CatchABus and others added 2 commits January 3, 2022 17:41

fix: qualifier matcher did not support multiple qualifiers for a sing…

c6c3292

…le file. (#9720)

feat(types-ios): iOS 15.2 (#9710)

4a384ca

delaneyb mentioned this pull request Jan 4, 2022

[@nativescript/facebook] androidx.fragment 1.3.0+ breaks navigation in nested frames NativeScript/plugins#218

Closed

NathanWalker and others added 18 commits January 4, 2022 15:21

fix: application instance creation occurs only within Application.run

88e355d

feat: new expression parser for xml bindings (#9729)

bb71526

feat(core): add event when disposeNativeView is called

55f6151

fix(time-picker): correction for super.disposeNativeView

c552ce9

feat(gestures): GestureEvents.gestureAttached added to modify native …

28665f5

…recognizers when needed

fix: better handling of states

36dc88b

chore: 8.2.0-alpha.1

ec1af6a

chore: adjust Application ios/android getters

411cdb5

feat(bindable): allow "global" context for expressions inside bindings (

4172e12

#9734)

feat(core): support RGB alpha notation (#9699)

2337d29

Functional notation: rgb[a](R G B[ / A]) CSS Colors Level 4 adds support for space-separated values in the functional notation. See https://www.w3.org/TR/css-color-4/#rgb-functions Co-authored-by: Nathan Walker <[email protected]>

feat(root-layout): support gradient colors on shade cover (#9626)

06c00d2

Co-authored-by: William Juan <[email protected]>

feat(ui): TouchManager for ease in adding interactivity

14c1b05

chore: property

2d7c63d

chore: cleanup

4e33807

chore: cleanup types

e2efec2

chore: cleanup

571bd37

feat: touch animations demo in toolbox

1ae7c56

chore: android demo

18361c0

NathanWalker and others added 12 commits January 22, 2022 13:14

chore: 8.2.0-alpha.3

7b44acc

chore: cleanup demo

a605180

fix: ensure android can access native app instance before bootstrap

e3cd87e

chore: update android manifest settings for demo apps

deacc2f

chore: 8.2.0-alpha.4

33d4424

fix(core): Application handling of nativeApp instance

4352ac6

feat: improved background handling (#9615)

27e3aa3

chore: 8.2.0-alpha.5

fb2f508

chore: cleanup background styling handling

0bcc2cf

chore: cleanup fragment handling for 1.3+ in addition to older

5adde10

chore: cleanup touchmanager

3a2cba8

Merge branch 'release/8.2.0' into fix/android-fragment-1.3.x

e730b5f

NathanWalker force-pushed the release/8.2.0 branch 4 times, most recently from c216027 to f58342b Compare February 18, 2022 20:52

NathanWalker force-pushed the release/8.2.0 branch from 7f90036 to b38337e Compare March 1, 2022 20:32

Base automatically changed from release/8.2.0 to master March 8, 2022 22:43

NathanWalker force-pushed the main branch from f234056 to a11ccd8 Compare June 26, 2025 18:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: androidx fragments 1.3+ #9728

fix: androidx fragments 1.3+ #9728

edusperoni commented Jan 3, 2022

Uh oh!

edusperoni commented Jan 3, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

fix: androidx fragments 1.3+ #9728

Are you sure you want to change the base?

fix: androidx fragments 1.3+ #9728

Conversation

edusperoni commented Jan 3, 2022

PR Checklist

What is the current behavior?

What is the new behavior?

Uh oh!

edusperoni commented Jan 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

edusperoni commented Jan 3, 2022 •

edited

Loading