Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(core): Font icons had incorrect fallback size in android #9914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2022
Merged

fix(core): Font icons had incorrect fallback size in android #9914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/core/image-source/index.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,14 +187,12 @@ export class ImageSource implements ImageSourceDefinition {
paint.setColor(color.android);
}

let scaledFontSize = layout.toDevicePixels(font.fontSize);
if (!scaledFontSize) {
// TODO: Consider making 36 font size as default for optimal look on TabView and ActionBar
scaledFontSize = layout.toDevicePixels(paint.getTextSize());
// TODO: Consider making 36 font size as default for optimal look on TabView and ActionBar
const scaledFontSize = layout.toDevicePixels(font.fontSize);
if (scaledFontSize) {
paint.setTextSize(scaledFontSize);
}

paint.setTextSize(scaledFontSize);

const textBounds = new android.graphics.Rect();
paint.getTextBounds(source, 0, source.length, textBounds);

Expand Down