fix: stop creating hooks on npm i in plugin folders.
#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
suggested changes
Feb 9, 2018
index.js
Outdated
| var packageJsonFile = path.join(dir, 'package.json'); | ||
| if (fs.existsSync(packageJsonFile)) { | ||
| var packageJsonContent = require(packageJsonFile); | ||
| isNativeScriptAppRoot = !!packageJsonContent.nativescript.id; |
There was a problem hiding this comment.
this will fail in case the package.json does not have nativescript key
8366815 to
d23723e
Compare
rosen-vladimirov
approved these changes
Feb 9, 2018
d23723e to
934158b
Compare
934158b to
f8ba6b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.