Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Unneeded dev dependencies should be removed after postclone.js finishes #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adrian-niculescu opened this issue Apr 24, 2019 · 3 comments
Labels

Comments

@adrian-niculescu
Copy link

Which platform(s) does your issue occur on?

  • All

Please, provide the following version numbers that your issue occurs with:

  • CLI: 5.3.3

Please, tell us how to recreate the issue in as much detail as possible.

After the postclone.js script finishes executing when the user runs npm run postclone there are some dev dependencies in src/package.json that are not used after this point. These are prompt and rimraf.
These should be removed by automatically by executing npm remove prompt rimraf in the finishSetup() function for example.
It goes without saying that unneeded dependencies increase the time npm install takes to execute and little by little the build takes minutes instead of seconds.

@EddyVerbruggen
Copy link

Those are devDependencies actually, so they should not end up in the final package on npm at all.

@adrian-niculescu
Copy link
Author

As I said, they increase the timenpm install takes to execute.

@adrian-niculescu adrian-niculescu changed the title Unneeded dependencies should be removed after postclone.js finishes Unneeded dev dependencies should be removed after postclone.js finishes Apr 24, 2019
@EddyVerbruggen
Copy link

Feel free to send a PR, I'm sure someone will be happy to merge it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants