Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Provide folder structure/workflow for Angular wrappers of UI plugins #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PeterStaev opened this issue Aug 15, 2019 · 3 comments
Open

Comments

@PeterStaev
Copy link

I can't find anywhere how should the plugin be structured and what should be the workflow when the plugin as an android code - for example the GridView or DropDown plugins.

@elena-p elena-p added the docs label Aug 19, 2019
@elena-p
Copy link

elena-p commented Aug 19, 2019

You could find more information on how to build angular wrappers here.

However, it would be a good improvement to include the steps in the plugin seed itself.

@PeterStaev
Copy link
Author

@elena-p , yes, I'm well aware of how wrappers should be built 😉 I'm more talking about to have in the seed a predefined structure where those wrappers should be put. Also I think best would be to have the postclone script automate this: so ask the user if their plugin will have angular wrappers, if Yes then:

  • Add a dummy wrapper in the predefined folder
  • Add angular compiler dependencies with their correct versions to the package.json file
  • Add angular compiler scripts to packages.json and include them in the build script
  • Automatically add the angular demo w/o prompting the user

Also it would be good if we can return and execute this part in the later stages so in case I start a plugin w/o angular wrappers I can later return and run some scripts that performs the above mentioned steps.

@elena-p elena-p changed the title Folder structure/workflow with Angular plugins? Provide folder structure/workflow for Angular wrappers of UI plugins Aug 19, 2019
@edusperoni
Copy link

I'd also like to add that the docs (https://docs.nativescript.org/angular/plugins/angular-plugin) do not mention the angular compiler at all, which results in many plugins not being compatible with AOT, for example: nativescript-community/ui-material-components#36

I've added a similar issue a while back: #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants