Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sedv8808
Copy link
Contributor

@sedv8808 sedv8808 commented Aug 7, 2023

I made some changes to be able to run the relevance prediction. Some booleans were requested to do string methods, ie, True.lower() which would yield errors.

There are also instances when doing the GDD call would bring in articles where the identifier was an empty list, this case was not handled and so, I would run into errors of translations.

Added to save the file as a csv just to be able to load the file easier when doing comparisons - can remove this once the debugging is finished.

@sedv8808 sedv8808 requested a review from SimonGoring August 7, 2023 21:43
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 71.42% and project coverage change: +0.01% 🎉

Comparison is base (c6f29b3) 52.42% compared to head (04857ee) 52.43%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   52.42%   52.43%   +0.01%     
==========================================
  Files          22       22              
  Lines        2394     2399       +5     
==========================================
+ Hits         1255     1258       +3     
- Misses       1139     1141       +2     
Files Changed Coverage Δ
.../article_relevance/relevance_prediction_parquet.py 64.94% <0.00%> (-0.38%) ⬇️
src/pipeline/entity_extraction_pipeline.py 47.54% <ø> (ø)
src/article_relevance/gdd_api_query.py 60.81% <83.33%> (+0.33%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SimonGoring SimonGoring merged commit 04857ee into main Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants