fix: Flux2 UI — sequence length and caption dropout labels no longer overlap#1460
Merged
Conversation
…widget overlap When supports_sequence_length=True, the sequence length widgets were placed at the outer `row` parameter (the frame's position in master) instead of a local row counter inside the frame. For Flux2 this value is 1, colliding with Caption Dropout which was hardcoded to row 1. Replaced all hardcoded row indices with a local counter that only advances for widgets that are actually rendered, matching the pattern already used in __create_text_encoder_n_frame. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Collaborator
Author
|
2 tasks
BitcrushedHeart
pushed a commit
to BitcrushedHeart/OneTrainer
that referenced
this pull request
Jun 20, 2026
…widget overlap (Nerogar#1460) Co-authored-by: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When selecting the Flux2 model type in the UI, the "Text Encoder Sequence Length" label/entry was rendered on top of the "Caption Dropout Probability" label/entry.
🤖 Generated with Claude Code