Remove dead text_encoder None-checks for models that always load their text encoders#1579
Merged
Merged
Conversation
…r TE Chroma, Qwen, Flux2, and ZImage never observe the include_text_encoder config flag in their model loaders, so their text encoder attribute is never None after loading. The is-None/truthy guards around it were dead code; drop them and make the calls unconditional. Co-Authored-By: Claude Sonnet 5 <[email protected]>
dxqb
added a commit
to dxqb/OneTrainer-hameerabbasi
that referenced
this pull request
Jul 5, 2026
These models always load their text encoder, but the checkpointing-refactor merge on this branch didn't pick up the None-check removal from Nerogar#1579 because the surrounding lines had already diverged. Co-Authored-By: Claude Sonnet 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
see title
Test plan
pre-commit run --all-filespasseswill test in merge branch
AI assistance